Skip to content

[O2B-1548] Migrate qc flag types overview model to use filtering model pattern#2100

Open
NarrowsProjects wants to merge 4 commits intoimprov/O2B-1534/Migrate-Log-Overview-to-use-FilteringModel-patternfrom
improv/O2B-1548/Migrate-qcFlagTypesOverviewModel-to-use-FilteringModel-pattern
Open

[O2B-1548] Migrate qc flag types overview model to use filtering model pattern#2100
NarrowsProjects wants to merge 4 commits intoimprov/O2B-1534/Migrate-Log-Overview-to-use-FilteringModel-patternfrom
improv/O2B-1548/Migrate-qcFlagTypesOverviewModel-to-use-FilteringModel-pattern

Conversation

@NarrowsProjects
Copy link
Collaborator

@NarrowsProjects NarrowsProjects commented Mar 9, 2026 •
edited
Loading

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • The 'bad' filter has been changed from multiple choice selection boxes to a collection of three radio buttons stating:
    • Bad
    • Not bad
    • Any

Notable changes for developers:

  • The qcFlagOverviewModel file now stores its filters in a FilteringModel instance.
  • The previous filters must now be accessed through the FilteringModel.get function

Changes made to the database:

  • N/A

@NarrowsProjects NarrowsProjects self-assigned this Mar 9, 2026
@NarrowsProjects NarrowsProjects requested a review from graduta as a code owner March 9, 2026 15:42
@NarrowsProjects NarrowsProjects added frontend javascript Pull requests that update Javascript code labels Mar 9, 2026
@codecov
Copy link

codecov bot commented Mar 9, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.83%. Comparing base (237683a) to head (27a8bbc).

Files with missing lines Patch % Lines
...s/QcFlagTypes/Overview/QcFlagTypesOverviewModel.js 0.00% 11 Missing ⚠️
...public/components/Filters/QcFlagTypesFilter/bad.js 0.00% 8 Missing ⚠️
...blic/components/common/selection/SelectionModel.js 0.00% 4 Missing ⚠️
...lagTypes/ActiveColumns/qcFlagTypesActiveColumns.js 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@                                          Coverage Diff                                           @@
##           improv/O2B-1534/Migrate-Log-Overview-to-use-FilteringModel-pattern    #2100      +/-   ##
======================================================================================================
+ Coverage                                                               45.82%   45.83%   +0.01%     
======================================================================================================
  Files                                                                    1041     1042       +1     
  Lines                                                                   17180    17175       -5     
  Branches                                                                 3106     3105       -1     
======================================================================================================
  Hits                                                                     7872     7872              
+ Misses                                                                   9308     9303       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NarrowsProjects NarrowsProjects force-pushed the improv/O2B-1548/Migrate-qcFlagTypesOverviewModel-to-use-FilteringModel-pattern branch from 0d89a8c to 27a8bbc Compare March 9, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isaachilly isaachilly Awaiting requested review from isaachilly

@graduta graduta Awaiting requested review from graduta graduta is a code owner

Assignees

@NarrowsProjects NarrowsProjects

Labels

frontend javascript Pull requests that update Javascript code

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@NarrowsProjects